Move map cache to monster #4788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramon-bernardo
commented
Sep 25, 2024
| @@ -218,7 +231,17 @@ class Monster final : public Creature | |||
| uint32_t getDamageImmunities() const override { return mType->info.damageImmunities; } | |||
| uint32_t getConditionImmunities() const override { return mType->info.conditionImmunities; } | |||
| void getPathSearchParams(const Creature* creature, FindPathParams& fpp) const override; | |||
| bool useCacheMap() const override { return !randomStepping; } | |||
There was a problem hiding this comment.
Override here. (monster)
| @@ -355,19 +354,12 @@ class Creature : virtual public Thing | |||
| decltype(auto) getStorageMap() const { return storageMap; } | |||
|
|
|||
| protected: | |||
| virtual bool useCacheMap() const { return false; } | |||
There was a problem hiding this comment.
Virtual creature function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
See above.