Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard tree search enhancement and tests #4781

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Sep 6, 2024

Pull Request Prelude

Changes Proposed

  • Add tests for the wildcard tree.
  • Improve codebase using auto where possible and renaming the search function for clarity.
  • Return a pair with an enum directly associated with Wildcard, instead of ReturnValue.
  • Rename the functions to snake_case.
  • Use std::shared_ptr instead raw pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants