Refactoring code for simplification and interoperability

[bircher]

I refactored the code to use only one form and most importantly I refactored the Account manager to work with the code from the frontend as submitted through the form rather than intercepting any request with a "code" argument.

[otarza]

Hi @bircher,

Thanks for the PR, I'll just test tomorrow and merge it.

[otarza]

@bircher I tried to test this on Drupal 8.4.5 but was unable to login. Got following errors:

Notice: Undefined index: access_token in Drupal\accountkit\AccountKitManager->getAccessToken() (line 112 of modules/custom/accountkit/src/AccountKitManager.php).

Notice: Undefined variable: user in Drupal\accountkit\AccountKitManager->userLoginFromCode() (line 56 of modules/custom/accountkit/src/AccountKitManager.php).

Notice: Undefined variable: user_name in Drupal\accountkit\AccountKitManager->userLoginFromCode() (line 59 of modules/custom/accountkit/src/AccountKitManager.php).

Notice: Undefined variable: user in Drupal\accountkit\AccountKitManager->userLoginFromCode() (line 71 of modules/custom/accountkit/src/AccountKitManager.php).

Also I found following errors in logs:
The access token was empty.
Error verifying the token in the 'access_token' type: OAuthException code: 190 fbtrace_id:BaeFucWKY9+

Maybe I'm missing something?

[bircher]

Hi @otarza I injected the externalauth and guzzle client services so that we don't need to call any drupal functions any more and that we can in the future unit test the manager service without making a request to facebook.

Also with the new exceptions it may be easier to debug what is going on.
And you will want to test it with Drupal 8.5 where forms have the messenger service so that we don't have to call drupal_set_message.