Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to latest pull requests #406

Merged
merged 22 commits into from
Sep 3, 2024
Merged

Conversation

Reco1I
Copy link
Contributor

@Reco1I Reco1I commented Sep 1, 2024

  • Beatmap options do not save its state at all. As an example if you set a custom offset it'll not be saved.
    Fixed
  • Block areas don't save its state at all too when first adding, that is once you open again the area manager the bug is fixed.
    Fixed
  • BeatmapProperties migration can potentially throw a ClassNotFoundException
    Fixed
  • Scores are not saving after gameplay.
    Fixed
  • Song menu filters (favorites and search) are not working.
    Fixed
  • When selecting a score from the scoreboard the ScoringScene shows the "Retry" button rather than the "Watch replay"
    Fixed
  • Some old devices get an IllegalStateException when navigating to game settings (Seems to be an Android issue)
    Fixed
  • Layouts with rounded corners are not being tinted in older Android versions, that is, android:backgroundTint doesn't take effect.
    Fixed
  • Checkboxes are invisible in the mod customization menu on older Android versions.
    Fixed
  • Replays always fail to load.
    Fixed
  • Score table migration can throw a ClassCastException in SDKs lower than 29
    Fixed
  • User should be able to access database file in order to backup.
    Solved
  • Classics spinners never finish.
    Fixed
  • New replays saving with absolute path instead of filename producing to not being found when trying to watch them.
    Fixed

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 1, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 1, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 2, 2024
@Reco1I Reco1I marked this pull request as ready for review September 2, 2024 03:47
@Reco1I
Copy link
Contributor Author

Reco1I commented Sep 2, 2024

Marked as ready for review.

@Rian8337 Rian8337 merged commit cf300cf into osudroid:master Sep 3, 2024
3 checks passed
@Reco1I Reco1I deleted the fix-things branch September 22, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants