Refactor obsolete code and QoL improvements #329
Draft
+1,379
−3,046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witch statements with proper if/if-else blocks
This can be changed to `checkPermissions` later on if desired, but for now the exception will be ignored.
…rary Prevent unnecessary locks as the underlying implementation of `Collections.synchronizedList()` is already synchronized, save for iterators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation to the previous large improvements PR to improve maintainability, reduce code footprint, and potentially improve performance, this PR will also consist of large changes (with core functionality unchanged). Things I deem unnecessary through testing will be deleted to reduce footprint.
Some unused classes may still remain as they may be an intrinsic part of the engine, though I have already deleted some useless and obsolete files. There may be some classes that are rewritten to Kotlin. I also might introduce minor QoL features or improvements (I accept suggestions too). Obsolete code will also be replaced with newer code if available.