Add redis environment: REDIS_PASS #730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skchqhdpdy
requested review from
7mochi,
NiceAesth,
cmyui and
infernalfire72
as code owners
|
a bit confused as to why this would work https://github.com/redis/docker-library-redis/blob/c5846c13383c8b284897ff171e0c946868ed4c8c/debian/docker-entrypoint.sh @7mochi any input? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In the docker-compose.yml file, the Redis section does not have an environment: entry, so the environment variables set in the .env file are not passed into the Docker container. I suspect this is why the redis-server always runs without a password.
I’m not very familiar with using Docker, so I asked ChatGPT, and the response was that the environment: entry is necessary for the password to be applied.
The YouTube link below shows videos I recorded myself using redis-cli.exe to connect.
https://youtu.be/72fQFjOm_I8
The first demonstration shows connecting when the environment: option is missing.
The second demonstration shows connecting when the option is present.
The third demonstration shows attempting to connect again when the option is missing.
Related Issues / Projects
Checklist