This repository has been archived by the owner on Jan 6, 2023. It is now read-only.
Add the APDS9960 proximity sensor kernel module #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pohly @jlaako @barbieri This PR is related to #39, they are used to enable the proximity sensors for solettaproject/soletta#1971. Please help to review |
| int i = 0; | ||
| struct i2c_adapter *adap = NULL; | ||
|
|
||
| for (i = 0; i < 10; i++) { |
There was a problem hiding this comment.
Is there any cleaner way to do this than just iterate max 10 times? Where does the number 10 come from? Maybe there is a function to fetch number of i2c adapters?
There was a problem hiding this comment.
I just want to enumerate all i2c adapters and find the one connected to external devices, but I did not find the API for the total i2c adapters. Since the total number is board related, and Galileo boards only have one i2c adapter, I changed the code to use adapter 0.
The apds9960 device driver needs a GPIO as the IRQ resource, Add this kernel module to provide the IRQ resource on Galileo boards Signed-off-by: Yong Li <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apds9960 device driver needs a GPIO as the IRQ resource,
Add this kernel module to provide the IRQ resource on Galileo boards
Signed-off-by: Yong Li [email protected]