Fix cosine_with_restarts: Don't override user-specified T_0 in cosine_with_restarts scheduler #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preserve user-specified T_0 parameter for restart cycles - Only use total_iters as T_0 fallback when T_0 not provided - Fixes issue where restarts were ignored due to T_0 override - Clean up total_iters parameter to prevent PyTorch errors
brandon-ykw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When using
cosine_with_restartsscheduler with custom T_0, the scheduler ignores user configuration and uses total_iters instead, resulting in single long decay instead of restart cycles.Solution
Added conditional logic to preserve user-specified T_0 while maintaining backward compatibility for configs that don't specify T_0.
Test plan