Remove deprecated types #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaZotov
requested changes
Oct 3, 2024
| @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Breaking changes | |||
| - Direct inference agent's subscription element is changed to `action_initiated` | |||
|
|
|||
| ### Changed | |||
| GenerationUtils::generateRelationBetween(ms_context, pair, replacement, ScKeynodes::rrel_1); | ||
| GenerationUtils::generateRelationBetween(ms_context, pair, variable, ScKeynodes::rrel_2); | ||
| ms_context->GenerateConnector(ScType::EdgeAccessConstPosTemp, variable, replacement); | ||
| ms_context->GenerateConnector(ScType::ConstTempPosArc, variable, replacement); |
There was a problem hiding this comment.
I think we can specify actuality here
There was a problem hiding this comment.
I don't think so
for one formula this substitution is actual, but there is a lot of solution trees in the kb and variables may have different substitutions at every formula usage
| @@ -28,7 +28,7 @@ class DeleteSolutionManager | |||
|
|
|||
| ScAddrList getListFromSet(ScAddr const & set) const; | |||
|
|
|||
| void deleteEdges(ScAddr const & source, ScType const & edge, ScAddr const & target) const; | |||
| void deleteConnectors(ScAddr const & source, ScType const & connectorType, ScAddr const & target) const; | |||
There was a problem hiding this comment.
Suggested change
| void deleteConnectors(ScAddr const & source, ScType const & connectorType, ScAddr const & target) const; | |
| void eraseConnectors(ScAddr const & source, ScType const & connectorType, ScAddr const & target) const; |
There was a problem hiding this comment.
check everywhere such prefixes as create, generate, erase, delete, remove, get, search, find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.