Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize navigation and history between SCg iframe and SCn visualizer #9

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

FallenChromium
Copy link
Contributor

@FallenChromium FallenChromium commented Feb 14, 2024

Depends on this commit in ostis-ai/sc-web from this PR

The idea is to notify react-sc-web of every command that is being executed in the SCg view, so that question addresses will be known even for non-default or custom commands. The synchronization works because the question address is being taken by the switcher from the current URL, it's getting updated aswell.

Points of uncertainty: make sure the iframe page does not get soft- or hard-reloaded in case scNavigation is used. Network requests show that this does not happen, but the time of DOM refresh seems suspicious to me. Could just be the speed of SCg 🤷‍♂️

@FallenChromium FallenChromium requested review from MikhailSadovsky and MksmOrlov and removed request for MikhailSadovsky February 14, 2024 14:08
@FallenChromium FallenChromium merged commit d3de852 into main Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants