Synchronize navigation and history between SCg iframe and SCn visualizer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FallenChromium
requested review from
MikhailSadovsky and
MksmOrlov
and removed request for
MikhailSadovsky
MksmOrlov
approved these changes
Feb 17, 2024
NikitaZotov
approved these changes
Feb 18, 2024
MikhailSadovsky
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on this commit in ostis-ai/sc-web from this PR
The idea is to notify react-sc-web of every command that is being executed in the SCg view, so that question addresses will be known even for non-default or custom commands. The synchronization works because the question address is being taken by the switcher from the current URL, it's getting updated aswell.
Points of uncertainty: make sure the iframe page does not get soft- or hard-reloaded in case
scNavigationis used. Network requests show that this does not happen, but the time of DOM refresh seems suspicious to me. Could just be the speed of SCg 🤷♂️