Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #222: fix audio stream stutter btween ovelay TS file; #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

issue #222: fix audio stream stutter btween ovelay TS file; #233

wants to merge 1 commit into from

Conversation

suzp1984
Copy link
Contributor

  1. let continuity_counter continually between overlay ts;
  2. copy audio data when transcoding ts;

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Nov 21, 2024
@suzp1984 suzp1984 force-pushed the issue/222-transcript-audio-stream branch from 559676a to 580c403 Compare November 21, 2024 17:12
@suzp1984
Copy link
Contributor Author

This PR try to fix #222 .

Here is how I verify this PR.

Because I didn't has openAI account to run the whole process. I change the code first by remove the openAI api and render the ASR to video stream code, then I can reproduce same problem described in #222.

Then I add this PR, the issue disappear. So I guess this PR works. Send it to review and let others to verify on real env.

@suzp1984 suzp1984 marked this pull request as ready for review November 21, 2024 17:18
@suzp1984 suzp1984 force-pushed the issue/222-transcript-audio-stream branch 2 times, most recently from fadc636 to 364276b Compare November 25, 2024 06:27
@suzp1984
issue ossrs#222: fix audio stream stutter btween ovelay TS file;
abdcf82 
1. let continuity_counter continually between overlay ts;
2. copy audio data when transcoding ts;
@suzp1984 suzp1984 force-pushed the issue/222-transcript-audio-stream branch from 364276b to abdcf82 Compare November 25, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suzp1984 @winlinvip