Skip to content

common-variable base_image changes / sonarqube fix #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

common-variable base_image changes / sonarqube fix #86

wants to merge 4 commits into from

Conversation

coryrobertsonmaxar
Copy link
Contributor

  • versions bumped in gradle.properties and Chart.yaml

  • edited dockerfile to take in parameter

  • edited jenkinsfile to pass base_image parameter into docker build command, grabbing base_image from common-variables artifact.

  • also fixed unresolved sonarqube issues.

@mjkresslein
Copy link
Contributor

@coryrobertsonmaxar Please review and resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkresslein mjkresslein Awaiting requested review from mjkresslein

@cadowner90 cadowner90 Awaiting requested review from cadowner90

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryrobertsonmaxar @mjkresslein