Skip to content

Conversation

@spencerschrock
Copy link
Member

What kind of change does this PR introduce?

bug fix

What is the current behavior?

The Pinned-Dependency check is dereferencing nil pointers on repos which use GitHub's new YAML anchor syntax in their workflows.
https://github.blog/changelog/2025-09-18-actions-yaml-anchors-and-non-public-workflow-templates/

What is the new behavior (if this is a feature change)?**

Ignore cases where the uses field isn't set. The value isn't actually empty in the testcase which triggered the panic, but our GitHub workflow library doesn't currently support parsing GitHub's new YAML anchors/aliases.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

@spencerschrock spencerschrock requested a review from a team as a code owner October 27, 2025 16:59
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team October 27, 2025 16:59
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.56%. Comparing base (353ed60) to head (aefe44a).
⚠️ Report is 264 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4832      +/-   ##
==========================================
+ Coverage   66.80%   69.56%   +2.75%     
==========================================
  Files         230      249      +19     
  Lines       16602    15503    -1099     
==========================================
- Hits        11091    10784     -307     
+ Misses       4808     3858     -950     
- Partials      703      861     +158     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The value isn't actually empty in the testcase which triggered the
panic, but our GitHub workflow library doesn't currently support parsing
GitHub's new  YAML anchors/aliases.

https://github.blog/changelog/2025-09-18-actions-yaml-anchors-and-non-public-workflow-templates/

Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants