Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the message and continue with next on error #438

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coni2k
Copy link
Contributor

@coni2k coni2k commented Aug 3, 2023

Fixes #437

Command for CSV output

go run .\cmd\criticality_score -gcp-project-id=[Project ID] -out=".\output\output.csv" ".\output\repos.txt"

The new CSV output after the update

repo.url,repo.language,repo.license,repo.star_count,repo.created_at,repo.updated_at,legacy.created_since,legacy.updated_since,legacy.contributor_count,legacy.org_count,legacy.commit_frequency,legacy.recent_release_count,legacy.updated_issues_count,legacy.closed_issues_count,legacy.issue_comment_frequency,legacy.github_mention_count,depsdev.dependent_count,__config_scorer_pike_depsdev_score
https://github.com/404/repo-not-found,,,,,,,,,,,,,,,,,NaN
https://github.com/babel/babel,TypeScript,MIT License,42433,2012-09-24T08:48:45Z,2023-08-02T22:03:56Z,132,0,1133,9,10.81,48,15081,14285,1.99,128779,8300887,0.87117

The output doesn't mention the error message; the user can check the console to see the details.

Alternatively, we could add a new field (Status?) that mentions the details ("OK", "Error: [Error message]").

And, there is one more "os.Exit(1)") at line 239, which might be handy to remove.

@sttor
Copy link

sttor commented Jul 22, 2024

are we planning to add this check anytime soon?

@Carmendelope
Copy link

Carmendelope commented Jul 31, 2024

Have you considered moving directly to the next repository without adding an entry with the information of the one that failed (We could continue processing the output files without having to modify anything.)

Just changing the return by a continue

On second thought I think your solution is better

@Carmendelope
Copy link

any news about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The process stops on error instead of continuing with the following repository.
3 participants