Change locking for Scorecard interface #478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
scClients
once globallyScorecard.Get
, useLock()/Unlock()
for reading from thescClients
map. This prevents two threads from independently reading the value, both deciding that there's noscClient
for their repo, and independently (but not concurrently) creating clients. Although they don't concurrently modify the map, thread 2 will overwrite thescClient
created by thread 1.Scorecard.Close
, useLock()/Unlock()
instead of the R-variants. This prevents the case where two threadsClose()
both reach theif !ok
line withok == true
, and then independently (but not concurrently) attemptingScRepoClient.Close
anddelete
.This should reduce overall repeated work by making the critical sections larger.