To support PostgreSQL v16 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecaat
reviewed
Jan 12, 2024
lib/pg_btree.c
Outdated
| @@ -529,6 +531,9 @@ _bt_mergeload(Spooler *self, BTWriteState *wstate, BTSpool *btspool, BTReader *b | |||
| /* the preparation of merge */ | |||
| itup = BTSpoolGetNextItem(btspool, NULL, &should_free); | |||
| itup2 = BTReaderGetNextItem(btspool2); | |||
| // #if PG_VERSION_NUM >= 160000 | |||
There was a problem hiding this comment.
I removed this line.
bin/recovery.c
Outdated
|
|
||
| static void GetSegmentPath(char path[MAXPGPATH], | ||
| #if PG_VERSION_NUM >= 160000 | ||
| RelFileLocator relNumber, |
There was a problem hiding this comment.
Since relNumber is a member of RelFileLocator, is it better s/relNumber/rlocator/g? Be careful that relNumber exists in other codes.
There was a problem hiding this comment.
I changed relNumber to rLocator
lib/reader.c
Outdated
| /* This API is published only from 9.1. | ||
| * This is used for permission check, but currently pg_bulkload | ||
| * is called only from super user and so the below code maybe | ||
| * is not essential. */ | ||
| ExecCheckRTPerms(range_table, true); | ||
| #endif | ||
|
|
||
| #if PG_VERSION_NUM >= 160000 | ||
| ExecInitRangeTable(checker->estate, range_table, perminfos); | ||
| checker->slot = MakeSingleTupleTableSlot(desc, &TTSOpsHeapTuple); |
There was a problem hiding this comment.
Is the line same as Line:480?
There was a problem hiding this comment.
I changed this line.
mikecaat
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.