Use configured local address over the one that is taken from the BGP session #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…session. This is needed in cases when using VRFs over GENEVE Tunnels where we bind the listening address to one internal IP for security reasons. Without this fix the local address was overridden with the listening address resulting in wrong nexthop advertisement.
fujita
reviewed
Aug 18, 2024
| @@ -879,6 +879,9 @@ func (s *BgpServer) toConfig(peer *peer, getAdvertised bool) *oc.Neighbor { | |||
| if state == bgp.BGP_FSM_ESTABLISHED { | |||
| peer.fsm.lock.RLock() | |||
| conf.Transport.State.LocalAddress, conf.Transport.State.LocalPort = peer.fsm.LocalHostPort() | |||
| if conf.Transport.Config.LocalAddress != "0.0.0.0" { | |||
There was a problem hiding this comment.
This was my initial change and then when tested things didnt worked as expected. So, added a log and this is the value I got. You think I should add also != "" ?
There was a problem hiding this comment.
@barlev-eddie maybe we can use STDLIB to check localhost, what will happen when user uses 127.0.0.1 / localhost fqdn?
|
Pushed, thanks. |
|
@fujita , thanks for handling it. I forgot about it due to family and work load. Do u want me to open another PR to change to the IPv4Unspecified() call ? |
|
Yeah, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use configured local address over the one that is taken from the BGP TCP connection.
This is needed in cases when using VRFs over GENEVE Tunnels where we bind the listening address to one internal IP for security reasons. Without this fix the local address was overridden with the listening address resulting in wrong nexthop advertisement.