ci: build with latest stable Go version #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using
go-version-file: 'go.mod', which refers to thego: 1.20directive ingo.mod. That means thatgo1.20.14was being used as the toolchain version. That's very out-of-date and no longer maintained. We have run into sporadic runtime fatal errors, and I believe that using a newer Go version will help with this.I could specify
'1.22'instead, if that's preferred. I chosestablejust because when future major Go versions are released, they will be picked up automatically on the next build-and-release GitHub Actions run.The version used to build a specific
gobgpdbinary can be found withgo version -m ./gobgpd.