Fix Silent #62
Merged
Fix Silent #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
|
As mentionned in 5ff64bd#r319766863, I think there is still an issue of |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
- Coverage 87.31% 87.1% -0.21%
=========================================
Files 6 6
Lines 922 923 +1
=========================================
- Hits 805 804 -1
- Misses 117 119 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line
OSQP.update_settings!(dest.inner; :verbose => false)does not seem to have any effect so this PR modifies thesettingsgiven tosetup!. This is the approach used in most MOI wrappers.