Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 5.0.5 #215

Merged
merged 9 commits into from
Nov 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
name: Publish plugin

on:
release:
types: [published]

push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'

jobs:
test:
runs-on: ubuntu-latest
permissions:
id-token: write # Required for authentication using OIDC

steps:
- name: Checkout
uses: actions/checkout@v3

# Note: This workflow uses the latest stable version of the Dart SDK.
# You can specify other versions if desired, see documentation here:
# https://github.com/dart-lang/setup-dart/blob/main/README.md
- uses: dart-lang/setup-dart@v1.4
- uses: dart-lang/setup-dart@v1.6.5
# - uses: dart-lang/setup-dart@9a04e6d73cca37bd455e0608d7e5092f881fd603

- name: Install dependencies
Expand All @@ -38,16 +36,6 @@ jobs:
- name: Format Coverage
run: dart pub global run coverage:format_coverage --packages=.dart_tool/package_config.json --report-on=lib --lcov -o ./coverage/coverage.lcov -i ./coverage

- name: Setup Pub Credentials
shell: bash
env:
PUB_DEV_PUBLISH_ACCESS_TOKEN: ${{ secrets.PUB_DEV_PUBLISH_ACCESS_TOKEN }}
PUB_DEV_PUBLISH_REFRESH_TOKEN: ${{ secrets.PUB_DEV_PUBLISH_REFRESH_TOKEN }}
PUB_DEV_PUBLISH_TOKEN_ENDPOINT: ${{ secrets.PUB_DEV_PUBLISH_TOKEN_ENDPOINT }}
PUB_DEV_PUBLISH_EXPIRATION: ${{ secrets.PUB_DEV_PUBLISH_EXPIRATION }}
run: |
sh ./pub_login.sh

- name: Check Publish Warnings
run: dart pub publish --dry-run

Expand All @@ -61,7 +49,7 @@ jobs:
needs: 'test'
permissions:
id-token: write # Required for authentication using OIDC
uses: dart-lang/setup-dart/.github/workflows/publish.yml@v1
uses: git-elliot/setup-dart/.github/workflows/publish.yml@main # Added build_runner step
with:
environment: 'pub.dev'
build_runner: true
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Change Log

## 5.0.5
Fixed compatibility for web

## 5.0.4
Updated dependencies, added tests, and updated GHA.

Expand Down
3 changes: 2 additions & 1 deletion lib/src/services/impls/mdns_scanner_service_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@
await for (final IPAddressResourceRecord ip
in iPAddressResourceRecordStream) {
final ActiveHost activeHost = convertSrvToHostName(
internetAddress: ip.address,
internetAddress:
InternetAddress.fromRawAddress(ip.address.rawAddress),

Check warning on line 129 in lib/src/services/impls/mdns_scanner_service_impl.dart

View check run for this annotation

Codecov / codecov/patch

lib/src/services/impls/mdns_scanner_service_impl.dart#L129

Added line #L129 was not covered by tests
ptr: ptr,
srv: srv,
);
Expand Down
36 changes: 0 additions & 36 deletions pub_login.sh

This file was deleted.

4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: network_tools
description: Networking Tools library which can help you discover open ports, devices on subnet and many other things.
version: 5.0.4
version: 5.0.5
issue_tracker: https://github.com/osociety/network_tools/issues
repository: https://github.com/osociety/network_tools

Expand Down Expand Up @@ -32,7 +32,7 @@ dependencies:
# Performing mDNS queries (e.g. Bonjour, Avahi).
multicast_dns: ^0.3.2+7
# A comprehensive, cross-platform path manipulation library for Dart.
path: ^1.9.1
path: ^1.9.0
# Process run helpers
process_run: ^1.2.2
# Yet another NoSQL persistent store database solution for single process io apps.
Expand Down
Loading