Highway Intersection Check

[brianjor]

Description:

Picked up where #643 left off.

Changes are:

• Flagging the highway and the node(s) that intersects with the powerline/waterway instead of the powerline/waterway
• Flags the way instead of just the edge

Test Results:

ISO	Total Flags	Sampled	Sampling %	TP	FP	False Positive Rate
ARG	10	10	100%	10	0	0%
AUS	9	9	100%	9	0	0%
TUR	18	18	100%	18	0	0%

[Bentleysb]

I'd be interested to see some examples of the true positive flags for this check. I am surprised there are Edges with power line or waterway tags. Those features generally become Lines.

[brianjor]

I'd be interested to see some examples of the true positive flags for this check. I am surprised there are Edges with power line or waterway tags. Those features generally become Lines.

Here is an example of a highway that has the power=line tag on it that also intersects another highway.

The selected way has both highway and power and intersects the "Ruta Nacional 156"
The way "Ruta Nacional 156" is the way that gets flagged.
https://www.openstreetmap.org/edit#map=17/-32.22399/-63.17634

In this example a bunch of highways intersect a highway + waterway (109263731)(https://www.openstreetmap.org/edit#map=18/-28.44676/-65.78058

It looks like the main fix to most of the flagged issues is to separate the way into highway and the waterway/power.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

92.4% Coverage
0.0% Duplication

[Bentleysb]

Looks good! Thanks for the example.