MixedCaseNameCheck Enhancements (without AutoFix) #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4573d4a
vladlemberg
changed the title
atiannicelli
previously approved these changes
Apr 30, 2021
Bentleysb
previously approved these changes
May 3, 2021
sayas01
reviewed
May 3, 2021
Comment on lines
140
to
143
| && !Validators.hasValuesFor(object, BrandTag.class) | ||
| && !Validators.hasValuesFor(object, ShopTag.class) | ||
| && !Validators.hasValuesFor(object, AmenityTag.class) | ||
| && !Validators.hasValuesFor(object, LeisureTag.class) |
There was a problem hiding this comment.
this could be combined as && !Validators.hasValuesFor(object, BrandTag.class, ShopTag.class, AmenityTag.class, LeisureTag.class)
|
Kudos, SonarCloud Quality Gate passed! |
Bentleysb
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please refer: #393
Check enhancements: #540
Potential Impact:
List potential impact to downstream libraries here (ex. atlas-checks, atlas-generator).
Unit Test Approach:
Add unit test for bug fix and more corner case coverage
Test Results:
passed