Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Dockerfile sandbox & docs #294

Merged
merged 5 commits into from
Jul 27, 2020
Merged

Conversation

danielduhh
Copy link
Collaborator

Description:

This adds a simple Dockerfile & documentation for local development use. By default, the gradlew command is exposed by the Docker container.

Steps for use:

  1. Create image
docker build --rm --tag [image name] .
  1. Create container from image and execute command
docker run [image name] [gradle command]

Example

docker build --rm --tag checks .
docker run checks run -Pchecks.local.checkFilter=SpikyBuildingCheck \
-Pchecks.local.countries=AIA

Fixes #289 #293

Potential Impact:

No downstream impact

Unit Test Approach:

Created and image and container. Was able to execute both gradlew build and run commands.

Test Results:

Tests pass!

@danielduhh danielduhh mentioned this pull request May 11, 2020
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Bentley Breithaupt <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@danielduhh
Copy link
Collaborator Author

Thanks @Bentleysb !

@danielduhh danielduhh merged commit e2cf984 into osmlab:dev Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

official docker image
2 participants