Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Suggestions] Building Road Intersections Check #392

Open
ylinzhi opened this issue Oct 19, 2020 · 1 comment
Open

[Fix Suggestions] Building Road Intersections Check #392

ylinzhi opened this issue Oct 19, 2020 · 1 comment

Comments

@ylinzhi
Copy link
Contributor

ylinzhi commented Oct 19, 2020

Which Atlas check is the fix suggestion related to?

Building Road Intersections Check
Description: https://github.com/osmlab/atlas-checks/blob/dev/docs/checks/buildingRoadIntersectionCheck.md
Script: https://github.com/osmlab/atlas-checks/blob/dev/src/main/java/org/openstreetmap/atlas/checks/validation/intersections/BuildingRoadIntersectionCheck.java

Describe more details of suggested fix(es)

Suggested Fix 1:

  • Type of fixing: Geometry fix

  • Operation: Delete

  • Suggested Action: Remove the building that intersect/overlap with a road

Is there any code enhancement needed if adding the fix suggestion component?

No

@sayas01
Copy link
Collaborator

sayas01 commented Nov 3, 2020

The check flags buildings that intersect the center lines of roads. I feel like the most appropriate fix is to update the geometry of the building to not intersect/overlap the road. Something like the lines that intersects the building could be updated to be so and so distance from the road. This will involve code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants