AutoFix suggestions for Building Road Intersection check (osmlab#392)

ladwlo · Jan 14, 2021 · 761877b · 761877b
1 parent 57154a4
commit 761877b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...rg/openstreetmap/atlas/checks/validation/intersections/BuildingRoadIntersectionCheck.java b/...rg/openstreetmap/atlas/checks/validation/intersections/BuildingRoadIntersectionCheck.java
@@ -10,6 +10,8 @@
 import org.openstreetmap.atlas.checks.base.BaseCheck;
 import org.openstreetmap.atlas.checks.flag.CheckFlag;
 import org.openstreetmap.atlas.geography.Location;
+import org.openstreetmap.atlas.geography.atlas.change.FeatureChange;
+import org.openstreetmap.atlas.geography.atlas.complete.CompleteEntity;
 import org.openstreetmap.atlas.geography.atlas.items.Area;
 import org.openstreetmap.atlas.geography.atlas.items.AtlasObject;
 import org.openstreetmap.atlas.geography.atlas.items.Edge;
@@ -39,6 +41,7 @@
  *
  * @author mgostintsev
  * @author sayas01
+ * @author ladwlo (autofix)
  */
 public class BuildingRoadIntersectionCheck extends BaseCheck<Long>
 {
@@ -128,6 +131,7 @@ protected Optional<CheckFlag> flag(final AtlasObject object)
                 ignoreTags());
         final CheckFlag flag = new CheckFlag(getTaskIdentifier(building));
         flag.addObject(building);
+        flag.addFixSuggestion(FeatureChange.remove(CompleteEntity.shallowFrom(building)));
         this.handleIntersections(intersectingEdges, flag, building);
         return flag.getPolyLines().size() > 1 ? Optional.of(flag) : Optional.empty();
     }

diff --git a/...penstreetmap/atlas/checks/validation/intersections/BuildingRoadIntersectionCheckTest.java b/...penstreetmap/atlas/checks/validation/intersections/BuildingRoadIntersectionCheckTest.java
@@ -37,6 +37,7 @@ public void testCheck()
     {
         this.verifier.actual(this.setup.getAtlas(), check);
         this.verifier.verifyExpectedSize(2);
+        this.verifier.verify(flag -> Assert.assertEquals(1, flag.getFixSuggestions().size()));
     }
 
     /**
@@ -77,6 +78,7 @@ public void testHighwayFilterConfig()
     {
         this.verifier.actual(this.setup.getCorewayIntersectionAtlas(), highwayFilterCheck);
         this.verifier.verifyExpectedSize(2);
+        this.verifier.verify(flag -> Assert.assertEquals(1, flag.getFixSuggestions().size()));
     }
 
     @Test
@@ -118,7 +120,7 @@ public void testSpanishCheck()
                     flag.getInstructions().contains("Edificio(id-323232) cruza calle(id-292929)"));
         });
         this.verifier.verifyExpectedSize(2);
-
+        this.verifier.verify(flag -> Assert.assertEquals(1, flag.getFixSuggestions().size()));
     }
 
     /**