🐛Fix: correct utterances theme when appearance is set to "auto" #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aron5055 is attempting to deploy a commit to the Osmium Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When
appearanceis set to"auto", the current implementation maps the theme to"preferred-color-scheme", which is not a valid value for thethemeparameter in Utterances.This PR updates the component to use the actual runtime color scheme from
useTheme()instead. Now"auto"mode correctly resolves to either"github-dark"or"github-light"at runtime.Why this matters
Without this fix, the Utterances comment box always defaults to its own theme, regardless of the site’s appearance. This causes inconsistency when using dark mode or switching themes.
The new behavior ensures that Utterances always aligns with the current site theme, making the comment section visually coherent.
Let me know if you'd prefer a different approach — happy to adjust!