Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create program day table #140

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Conversation

soroushowji-tomtom
Copy link
Contributor

@soroushowji-tomtom soroushowji-tomtom commented Oct 11, 2023

Screen.Recording.2023-10-12.at.15.58.37.mov

created html tables

add fonts
add cell types
add image
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for whimsical-buttercream-efd44b ready!

Name Link
🔨 Latest commit ffc092c
🔍 Latest deploy log https://app.netlify.com/sites/whimsical-buttercream-efd44b/deploys/652cf37f4c857f00096e95b7
😎 Deploy Preview https://deploy-preview-140--whimsical-buttercream-efd44b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soroushowji-tomtom ! Great job ! 👍

2 requests:

  • Could you run Prettier ?
  • Could you improve the layout on mobile (make the table always take the full width) ?

@soroushowji-tomtom
Copy link
Contributor Author

Thanks @soroushowji-tomtom ! Great job ! 👍

2 requests:

  • Could you run Prettier ?
  • Could you improve the layout on mobile (make the table always take the full width) ?

I ran the prettier now, thanks for mentioning it.
For the layout improvement, tables are famously bad on mobile view but this one at least looks nice if you use the phone on widescreen view and you can scroll and copy and all that good stuff.
This is not a picture so it will try to fit your screen the best way possible.

@soroushowji-tomtom soroushowji-tomtom marked this pull request as ready for review October 16, 2023 08:26
@xivk xivk self-requested a review October 17, 2023 14:04
@xivk xivk merged commit 5d20456 into main Oct 17, 2023
@xivk xivk deleted the feature/create-program-day-table branch October 17, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants