Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map submission #119

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Map submission #119

merged 9 commits into from
Sep 26, 2023

Conversation

nobohan
Copy link
Contributor

@nobohan nobohan commented Sep 25, 2023

Hello,

This is a PR for adding a new page "Call for maps" to the website, based on the "Call for presentation" page.

New button on the home page:

image

New page:

image

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for whimsical-buttercream-efd44b ready!

Name Link
🔨 Latest commit 31fdd62
🔍 Latest deploy log https://app.netlify.com/sites/whimsical-buttercream-efd44b/deploys/6512dbc403ffc60008c35331
😎 Deploy Preview https://deploy-preview-119--whimsical-buttercream-efd44b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you see in the checks, it doesn't build!
Please make the necessary changes.

@marjanvandekauter-tomtom
Copy link
Contributor

@nobohan can you please update the pull request and use the reviewed version of the call that I sent you from the SotM-EU email address? Also, please use the button text "Submit your maps".

@jbelien please hold off on merging this request until the content has been updated by Julien.

Thanks both!

@nobohan
Copy link
Contributor Author

nobohan commented Sep 25, 2023

@marjanvandekauter-tomtom Sorry Marjan, I had forgotten to add your changes! This is done now.

@jbelien I also corrected 2 things and I guess it is passing the tests now.

@marjanvandekauter-tomtom
Copy link
Contributor

The content looks good now.

Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header looks strange now that there are 2 buttons.
Could you improve the layout a bit ?

Capture d’écran 2023-09-25 à 15 40 54

Please also add the "Submit your maps" link under "Get your tickets" in the mobile menu.

Capture d’écran 2023-09-25 à 15 40 58

Thanks.

Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, don't forget to run Prettier!

@nobohan
Copy link
Contributor Author

nobohan commented Sep 25, 2023

For mobile, I moved the "submit your maps" button to the bottom of the page just before the sponsors, and add it in the mobile hamburger menu.

image

image

@marjanvandekauter-tomtom
Copy link
Contributor

Looking at the time, I think we might have to change the "Call for maps open" date in the Deadline section to September 26?

@marjanvandekauter-tomtom
Copy link
Contributor

marjanvandekauter-tomtom commented Sep 26, 2023

@jbelien have the requested changes been made and can the merging process continue (after changing the call date--see comment above)?

@jbelien
Copy link
Member

jbelien commented Sep 26, 2023

Looking at the time, I think we might have to change the "Call for maps open" date in the Deadline section to September 26?

Updated in 31fdd62

@jbelien have the requested changes been made and can the merging process continue (after changing the call date--see comment above)?

I've made the necessary changes. I'll merge in a few minutes.

@jbelien jbelien merged commit f57c236 into osmbe:main Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants