Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landcover=* #9

Closed
wants to merge 9 commits into from
Closed

Landcover=* #9

wants to merge 9 commits into from

Conversation

pietervdvn
Copy link

I like landcovers more then some landuses!

Closes #6 ; let's try it out!

@jbelien jbelien self-assigned this Mar 26, 2018
@jbelien jbelien self-requested a review March 26, 2018 13:32
@jbelien
Copy link
Member

jbelien commented Mar 26, 2018

Hey @pietervdvn ,

Thanks for trying this out !
Obviously, I won't merge it right away ; let's first see what people think about it :)

Could you first resolve the conflicting file : landcover.mss ?
Thanks !

Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you first resolve the conflicting file : landcover.mss ?

@pietervdvn
Copy link
Author

The conflict has been resolved

@jbelien
Copy link
Member

jbelien commented Mar 26, 2018

Could you also make sure openstreetmap-carto.lua and openstreetmap-carto.style with the necessary tags ?

landcover.mss Outdated Show resolved Hide resolved
landcover.mss Outdated Show resolved Hide resolved
landcover.mss Outdated Show resolved Hide resolved
landcover.mss Outdated Show resolved Hide resolved
landcover.mss Outdated Show resolved Hide resolved
@jbelien
Copy link
Member

jbelien commented Mar 26, 2018

Seems good ! Thanks @pietervdvn !

I'll keep you updated when it's available (I would say first week of April at best).

@pietervdvn
Copy link
Author

pietervdvn commented Mar 26, 2018 via email

landcover.mss Outdated Show resolved Hide resolved
@jbelien jbelien closed this May 1, 2020
@jbelien
Copy link
Member

jbelien commented May 1, 2020

Not sure exactly what I did that closed that branch automatically (I guess it was the branch renaming).

Following the work done with Champs-Libres to improve our OSMBE tileserver, I decided to simplify the openstreetmap-carto-be repository.
I'll keep here only the required files in a branch with the openstreetmap-carto release number.

I think this PR is still relevant. Could you create a new PR with only the necessary files and modifications to branch 5.1 ? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants