Transition to Ultranest #205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sampling is no longer performed with pymultinest(multinest) but with ultranest. A reasonable speedup is also seen.
NormalizerSimultan now also uses Ultranest for the sampling of the posterior. The implementation is not yet vectorized and fairly slow as there are a lot of extra code. Significant speedup can be obtained by rewriting the lnlike function to be more vector friendly.
We want to suppress the visualization of ultranest when ran in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pymulitinest package relies on the user having multinest built and installed somewhere on their system. This adds unnecessary complexity when users installs OMpy. To avoid this issue I've rewritten the
NormalizerNLDandNormalizerSimultanto use the Ultranest package, rather than pymultinest.TODO:
The way the
lnlikefunction is implemented inNormalizerSimultanis very costly and not simple to vectorize. This should be rewritten to allow for vectorized calls. This will require some modification to theNormalizerGSFclass too.This PR will eventually be closing #204