fixed saveResponse and readResponse with paths with unicode chars

oscarotero · Mar 11, 2016 · fb6627b · fb6627b
1 parent 858eabf
commit fb6627b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/Utils/FileTrait.php b/src/Utils/FileTrait.php
@@ -53,7 +53,8 @@ public function appendQuery($appendQuery = true)
      */
     private function getFilename(RequestInterface $request, $indexExt = 'html')
     {
-        $parts = pathinfo($request->getUri()->getPath());
+        $path = urldecode($request->getUri()->getPath());
+        $parts = pathinfo($path);
         $path = isset($parts['dirname']) ? $parts['dirname'] : '';
         $filename = isset($parts['basename']) ? $parts['basename'] : '';
 

diff --git a/tests/SaveReadResponseTest.php b/tests/SaveReadResponseTest.php
@@ -11,15 +11,23 @@ public function saveProvider()
                 '/hello-world',
                 '/hello-world/index.html',
                 'Hello world',
-            ], [
+            ],
+            [
                 '/post',
                 '/post/index.html',
                 'This is a post',
-            ], [
+            ],
+            [
+                '/Os miúdos camiños',
+                '/Os miúdos camiños/index.html',
+                'This is a post with spaces and tildes',
+            ],
+            [
                 '/index.json',
                 '/index.json',
                 '{"hello": "world"}',
-            ], [
+            ],
+            [
                 '/',
                 '/index.html',
                 'Index',