tests/CI: Add runners for RHEL 9.7 and 10.1 (HMS-6278) #4716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoscieln
force-pushed
the
add_rhel_9.7_10.1_runners
branch
2 times, most recently
from
77417ef to
ff3d96e
Compare
|
/jira-epic HMS-6072 |
schutzbot
changed the title
croissanne
force-pushed
the
add_rhel_9.7_10.1_runners
branch
from
8864be5 to
95b3bcf
Compare
tkoscieln
force-pushed
the
add_rhel_9.7_10.1_runners
branch
11 times, most recently
from
d81df31 to
7fb4002
Compare
tkoscieln
requested review from
mvo5,
achilleas-k and
thozza
and removed request for
a team
|
PR is ready for review now. It introduces the new RHEL 9.7 and 10.1 runners into our CI, but also includes a fix for missing slashes in snapshot |
thozza
reviewed
May 29, 2025
There was a problem hiding this comment.
Thank you for the PR!
The first commit contains unrelated or unneeded changes.
I have two additional questions:
- Did you consider fixing the satellite regression test to work with the rpmrepo snapshot URLs that are missing the last backslash? I'm asking because other test cases seem to work just fine without it (at least you didn't express that they don't), so fixing the test case seems like a good idea, compared to keeping this unexpected behavior in the test and risking that we will have to spend time debugging the same thing in the future.
- Do you plan to submit a follow-up to move the GA runners from 9.5 to 9.6 and also adding 10.0 ga runners?
Well since all of the other distros use the slash in the base_url, I thought I will just edit these to contain them as well. But on the other hand yes, I do not like the way the test handles the url creation. So we can just leave it as is or we can add a condition into the test (or edit the url creation itself).
Yes, I plan to do that asap. |
tkoscieln
force-pushed
the
add_rhel_9.7_10.1_runners
branch
2 times, most recently
from
be3fb24 to
47011b1
Compare
Add runners for RHEL 9.7 and 10.1 and remove 9.6 and 10.0 runners.
Add compose request output print in case of failure.
In repository files for RHEL 9.7 and 10.1, there were missing slashes at the end of the baseurl which caused the satellite regression tests to fail. The refresh job only subs the snapshot dates and leaves the rest of the url unchanged.
…sion The cross distro test started failing on RHEL 10.1, because the osbuild/images version was a Go pseudo-version that the sed command parsing the version did not recognize.
tkoscieln
force-pushed
the
add_rhel_9.7_10.1_runners
branch
from
47011b1 to
1b33061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runners for RHEL 9.7 and 10.1 and remove 9.6 and 10.0 runners.
JIRA: HMS-6278