Wizard: Add validation to Timezone select (HMS-5493) #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently there is no error status displayed next to the nav item of the step, this PR will fix that: #2878 |
|
/jira-epic HMS-5008 |
schutzbot
changed the title
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
- Coverage 82.09% 82.07% -0.03%
==========================================
Files 207 207
Lines 23293 23313 +20
Branches 2286 2289 +3
==========================================
+ Hits 19122 19133 +11
- Misses 4144 4153 +9
Partials 27 27
Continue to review full report in Codecov by Sentry.
|
regexowl
force-pushed
the
timezone-field-validation
branch
2 times, most recently
from
c6fda71 to
46b1cc8
Compare
This adds the timezones to the step validation and renders an error when an invalid timezone is imported. How to test: 1. import a blueprint with invalid timezone "foo" 2. select a target 3. go to Registration step 4. click on "Review and finish" button Current behaviour: - the "Create" button is disabled, but when navigating to Timezone step no error is displayed After update: - there is an error rendered under the timezone select
regexowl
force-pushed
the
timezone-field-validation
branch
from
46b1cc8 to
641bf09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the timezones to the step validation and renders an error when an invalid timezone is imported.
How to test:
Current behaviour:
After update:
JIRA: HMS-5493