Wizard: Remove first boot script from services when no script (HMS-5481) #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexowl
force-pushed
the
fix-first-boot
branch
from
0edfac9 to
3fc41bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2871 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 207 207
Lines 23293 23300 +7
Branches 2286 2291 +5
=======================================
+ Hits 19122 19129 +7
Misses 4144 4144
Partials 27 27
Continue to review full report in Codecov by Sentry.
|
lucasgarfield
previously approved these changes
Feb 10, 2025
|
/jira-epic HMS-5279 |
schutzbot
changed the title
regexowl
force-pushed
the
fix-first-boot
branch
from
3fc41bc to
f6a3a1d
Compare
It would be for sure. Making the code block work properly with the tests is a bit of pain, but tried to add one which uses the upload function with an empty script (body of the code block does not seem reachable via testing-library methods). |
regexowl
force-pushed
the
fix-first-boot
branch
from
f6a3a1d to
a335b21
Compare
There is a bug that makes `custom-first-boot` service stay in services when the first boot script is removed. How to reproduce: 1. create a blueprint with a first boot script 2. download the blueprint and confirm `custom-first-boot` was added to enabled services 3. click on "Edit blueprint" 4. go to First boot step and remove the script 5. save edited blueprint Current behaviour: - `custom-first-boot` service should be still enabled even with the removed first boot script Updated behaviour: - `custom-first-boot` is no longer in the blueprint after first boot script got removed
regexowl
force-pushed
the
fix-first-boot
branch
from
a335b21 to
0226386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that makes
custom-first-bootservice stay in services when the first boot script is removed.How to reproduce:
custom-first-bootwas added to enabled servicesCurrent behaviour:
custom-first-bootservice should be still enabled even with the removed first boot scriptUpdated behaviour:
custom-first-bootis no longer in the blueprint after first boot script got removedJIRA: HMS-5481