Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for fully sourced container stack (HMS-3883) #1885

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schuellerf
Copy link
Collaborator

Getting the stack up and running locally but all from source

@lucasgarfield
Copy link
Collaborator

npm run lint:js:fix should get the unit tests passing for you 😉

@schuellerf
Copy link
Collaborator Author

schuellerf commented Apr 4, 2024

npm run lint:js:fix should get the unit tests passing for you 😉

I had this locally also it just looks weird, and it's still a draft anyway 😇

@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 759e966 to fc6bd00 Compare April 4, 2024 13:26
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 4b239a9 to 7525329 Compare April 23, 2024 17:48
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 7525329 to f2dd9ed Compare May 8, 2024 17:38
Copy link
Contributor

github-actions bot commented Jun 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 8, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jun 15, 2024
@schuellerf schuellerf reopened this Sep 6, 2024
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from f2dd9ed to d713c92 Compare September 6, 2024 14:28
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 33 lines in your changes missing coverage. Please review.

Project coverage is 82.04%. Comparing base (fd4fe79) to head (99acde8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fec.config.js 0.00% 26 Missing ⚠️
src/store/service/emptyImageBuilderApi.ts 30.00% 7 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   82.16%   82.04%   -0.12%     
==========================================
  Files         207      207              
  Lines       23235    23270      +35     
  Branches     2280     2282       +2     
==========================================
+ Hits        19090    19092       +2     
- Misses       4118     4151      +33     
  Partials       27       27              
Files with missing lines Coverage Δ
src/AppEntry.tsx 0.00% <ø> (ø)
src/store/service/emptyImageBuilderApi.ts 80.55% <30.00%> (-19.45%) ⬇️
fec.config.js 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc680f...99acde8. Read the comment docs.

@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from d713c92 to 234b8c5 Compare September 6, 2024 15:13
@github-actions github-actions bot removed the Stale label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 7, 2024
@schuellerf schuellerf removed the Stale label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 7, 2024
@schuellerf schuellerf removed the Stale label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 8, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Dec 16, 2024
@schuellerf schuellerf reopened this Dec 16, 2024
@github-actions github-actions bot removed the Stale label Dec 17, 2024
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added Stale and removed Stale labels Jan 17, 2025
@schuellerf schuellerf force-pushed the HMS-3883-fully-source-containers branch from 234b8c5 to 99acde8 Compare February 12, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants