Skip to content

Konflux build pipeline service account migration #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

red-hat-konflux[bot]
Copy link
Contributor

Build pipeline Service Account migration

This PR changes Service Account used by build pipeline from "appstudio-pipeline" to dedicated to the Component Service Account.
Please merge the Service Account update to avoid broken builds when deprected "appstudio-pipeline" Service Account is removed.

Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it very hard to review this diff as it contains a ton of whitespace and other non-functional changes (like moving from " -> '. It seems it is indeed adding a new 'serviceAccountName`. I'm inclined to just merge it if the tekton run is green

@shi2wei3
Copy link
Contributor

I find it very hard to review this diff as it contains a ton of whitespace and other non-functional changes (like moving from " -> '. It seems it is indeed adding a new 'serviceAccountName`. I'm inclined to just merge it if the tekton run is green

pipelinerun failed on build-container-s390x task with

Error allocating host: timed out waiting for instance address

could you help to comment /retest to try it again?

@mvo5
Copy link
Collaborator

mvo5 commented Apr 28, 2025

/retest

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: konflux <[email protected]>
@mvo5 mvo5 force-pushed the konflux-sa-migration-bootc-image-builder branch from a924853 to 2e8e190 Compare May 5, 2025 07:10
@shi2wei3
Copy link
Contributor

shi2wei3 commented May 6, 2025

Konflux build/test pipelines are green, I think we can merge this PR.
If you hide the whitespace in diff, it's mainly aimed to add

  taskRunTemplate:
    serviceAccountName: build-pipeline-bootc-image-builder

Copy link

github-actions bot commented Jun 6, 2025

This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days.

@github-actions github-actions bot added the Stale Issue or PR with no activity for extended period of time label Jun 6, 2025
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issue or PR with no activity for extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants