ldap: Fix autodiscovery for Active Directory #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for automatically discovering the closest domain controller (LDAP server) by asynchronously connecting to all domain controllers advertised in DNS, sorted by priority and weight, in parallel and using the first server to respond. The protocol is described by Microsoft at https://technet.microsoft.com/en-us/library/cc978016.aspx
greezybacon
force-pushed
the
issue/ldap-auto-discovery-v2
branch
from
72a39e8 to
39d1cb2
Compare
auth-ldap/authentication.php
Outdated
| $sockets = array(); | ||
| reset($servers); | ||
| $closest = null; | ||
| $loops = 60; # 6 seconds max |
There was a problem hiding this comment.
Actually, with 2ms loop timing, this is 120ms (which is probably a long enough delay)
auth-ldap/authentication.php
Outdated
| if (!in_array($error, array(SOCKET_EINPROGRESS, SOCKET_EALREADY))) { | ||
| // Bad mojo | ||
| socket_close($sk); | ||
| unset($sockets,$i); |
There was a problem hiding this comment.
unset($sockets[$i]);
|
@greezybacon: What is the status of this feature/pr several years after? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple problems with the current autodiscover protocol in the plugin:
This patch adds support for automatically discovering the closest domain controller (LDAP server) by asynchronously connecting to all domain controllers advertised in DNS, sorted by priority and weight, in parallel and using the first server to respond.
The protocol is described by Microsoft at
https://technet.microsoft.com/en-us/library/cc978016.aspx