Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocked state #4204

Closed
wants to merge 35 commits into from
Closed

Conversation

walmadhagi
Copy link

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

malosayli and others added 30 commits October 15, 2024 21:22
This commit introduces the following changes:
- Add SMS template for recovery code
- Update config to support SMS recovery
- Extend identity schema for recovery settings
- Modify recovery strategy to handle SMS code delivery
- Update gitignore to exclude new development files

These changes enable users to receive recovery codes via SMS,
enhancing the account recovery options and improving user experience.
feat: Implement recovery code via SMS
This change introduces a new feature to track failed login attempts and
deactivate accounts after a configured number of failures within a specified
time window. The main components of this change include:

1. New database table for storing login attempts (currently only failed attempts)
2. Updated password login strategy to record failed attempts
3. Logic to deactivate accounts when max attempts are exceeded
4. Configuration options for max attempts and time window
5. New error messages for account deactivation due to failed attempts

This enhancement improves security by preventing brute-force attacks and
adds a layer of protection for user accounts.
feat: Implement login attempt tracking and account deactivation
- Add new master.yaml workflow for CI/CD pipeline
- Build and push Docker images for x86 and arm64 architectures
- Utilize GitHub Container Registry (ghcr.io)
- Move existing workflows to .github/workflows/old/ directory
- Streamline CI process for master branch and tag releases
feat: reactivate inactive account on recovery
Adds functionality to automatically deactivate identities that have been inactive
for a configurable period.

Key changes:
- Add config option for inactivity threshold period
- Add API endpoint to list and deactivate inactive identities
- Add SQL queries to find and update inactive identities
- Add manager and persister methods to handle deactivation
This commit introduces the following changes:
- Add SMS template for recovery code
- Update config to support SMS recovery
- Extend identity schema for recovery settings
- Modify recovery strategy to handle SMS code delivery
- Update gitignore to exclude new development files

These changes enable users to receive recovery codes via SMS,
enhancing the account recovery options and improving user experience.
This change introduces a new feature to track failed login attempts and
deactivate accounts after a configured number of failures within a specified
time window. The main components of this change include:

1. New database table for storing login attempts (currently only failed attempts)
2. Updated password login strategy to record failed attempts
3. Logic to deactivate accounts when max attempts are exceeded
4. Configuration options for max attempts and time window
5. New error messages for account deactivation due to failed attempts

This enhancement improves security by preventing brute-force attacks and
adds a layer of protection for user accounts.
- Add new master.yaml workflow for CI/CD pipeline
- Build and push Docker images for x86 and arm64 architectures
- Utilize GitHub Container Registry (ghcr.io)
- Move existing workflows to .github/workflows/old/ directory
- Streamline CI process for master branch and tag releases
Adds functionality to automatically deactivate identities that have been inactive
for a configurable period.

Key changes:
- Add config option for inactivity threshold period
- Add API endpoint to list and deactivate inactive identities
- Add SQL queries to find and update inactive identities
- Add manager and persister methods to handle deactivation
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ wasim almadhagi
❌ aalkhodiry
❌ malosayli


wasim almadhagi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@walmadhagi walmadhagi closed this Nov 12, 2024
@aalkhodiry aalkhodiry deleted the add-blocked-state branch November 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants