Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explicit config flag for secure cookies #4180

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 29, 2024

Adds a new config flag for session and all other cookies. Falls back to the previous behavior of using the dev mode to decide if the cookie should be secure or not.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Adds a new config flag  for session and all other cookies. Falls back to the previous behavior of using the dev mode to decide if the cookie should be secure or not.
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (77beb4d) to head (c34b353).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
driver/config/config.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4180      +/-   ##
==========================================
- Coverage   78.57%   78.57%   -0.01%     
==========================================
  Files         380      380              
  Lines       27103    27111       +8     
==========================================
+ Hits        21297    21303       +6     
- Misses       4188     4190       +2     
  Partials     1618     1618              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 2aabe12 into master Oct 29, 2024
31 checks passed
@aeneasr aeneasr deleted the add-config-for-secure branch October 29, 2024 16:21
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
Adds a new config flag  for session and all other cookies. Falls back to the previous behavior of using the dev mode to decide if the cookie should be secure or not.
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
Adds a new config flag  for session and all other cookies. Falls back to the previous behavior of using the dev mode to decide if the cookie should be secure or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant