-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: passwordless SMS and expiry notice in code / link templates #4104
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4104 +/- ##
==========================================
- Coverage 78.60% 78.58% -0.03%
==========================================
Files 377 378 +1
Lines 26914 26966 +52
==========================================
+ Hits 21156 21190 +34
- Misses 4148 4166 +18
Partials 1610 1610
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey 👋🏻 , thanks for all the great work you do on Ory. I am very interested in this feature, providing the ability to support a passwordless login based on an SMS OTP. Just wondering would the flow for this authentication method be for the user to provide their phone number and then based on that identifier being present in the database it will send an SMS code to the phone number? Similar to how the Email OTP works? |
The feature behaves the same, it's just supporting another notification channel now. |
Great, apologies for another question. To expand upon this will the user supply their email address or phone number and based on that send the login code to the relevant notification channel? For example, sending the following request would send an email notification:
And sending the following request would send an SMS notification, providing the phone number is an identifier?
or can we supply the email address as the identifier but send an SMS OTP instead, perhaps with an additional parameter?
|
This patch allows Ory Kratos to use the SMS gateway for login and registration with code via SMS.
Co-authored-by: Jonas Hungershausen <[email protected]>
c9498ed
to
dfa858c
Compare
Thank you for working on this new behaviour, just wondering if there is an ETA for a new release to be made which includes this new feature? :) |
This feature allows Ory Kratos to use the SMS gateway for login and registration with code via SMS.
Additionally, the default email and sms templates have been updated. We now also expose
ExpiresInMinutes
/expires_in_minutes
in the templates, making it easier to remind the user how long the code or link is valid for.Related issue(s)
Closes #1570
Closes #3779
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments