Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor API in package cipher for easier dependency injection #4103

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Sep 16, 2024

@alnr alnr self-assigned this Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (3215792) to head (ab14d61).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
driver/registry_default.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4103      +/-   ##
==========================================
- Coverage   79.00%   78.51%   -0.49%     
==========================================
  Files         377      376       -1     
  Lines       27492    26755     -737     
==========================================
- Hits        21720    21007     -713     
+ Misses       4165     4148      -17     
+ Partials     1607     1600       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alnr alnr merged commit 9aefc0a into master Sep 16, 2024
29 checks passed
@alnr alnr deleted the alnr/cipher-secrets branch September 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants