Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove comment because the upstream issue has been fixed #3442

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

efesler
Copy link
Contributor

@efesler efesler commented Aug 17, 2023

The comment triggered ORY Closed Reference Notifier GitHub action. However, this is not relevant anymore.

Resolve: #2630

Related issue(s)

#2630

Checklist

  • I have read the contributing guidelines.
  • [ x I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [ x I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

been fixed

The comment triggered ORY Closed Reference Notifier GitHub action.
However, this is not relevant anymore.

Resolve: ory#2630
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2023

CLA assistant check
All committers have signed the CLA.

@efesler efesler changed the title fix: Remove comment because the upstream issue has fix: remove comment because the upstream issue has been fixed Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #3442 (8bb0d1d) into master (8bb0d1d) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 8bb0d1d differs from pull request most recent head 2ae3f08. Consider uploading reports for the commit 2ae3f08 to get more accurate results

@@           Coverage Diff           @@
##           master    #3442   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files         327      327           
  Lines       21596    21596           
=======================================
  Hits        16846    16846           
  Misses       3494     3494           
  Partials     1256     1256           

@aeneasr aeneasr merged commit bb25276 into ory:master Aug 22, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream reference closed: github.com/fsnotify/fsnotify/issues/340
3 participants