Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change react-native port to 19006 #3438

Closed
wants to merge 5 commits into from

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

aeneasr
aeneasr previously approved these changes Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3438 (b727b16) into master (157d934) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head b727b16 differs from pull request most recent head 859003f. Consider uploading reports for the commit 859003f to get more accurate results

@@            Coverage Diff             @@
##           master    #3438      +/-   ##
==========================================
- Coverage   78.01%   78.00%   -0.01%     
==========================================
  Files         327      326       -1     
  Lines       21553    21527      -26     
==========================================
- Hits        16814    16792      -22     
+ Misses       3487     3482       -5     
- Partials     1252     1253       +1     
Files Changed Coverage Δ
identity/handler.go 86.20% <100.00%> (ø)
identity/manager.go 74.88% <100.00%> (ø)

... and 2 files with indirect coverage changes

@aeneasr aeneasr enabled auto-merge (squash) August 16, 2023 20:15
@jonas-jonas jonas-jonas marked this pull request as draft August 17, 2023 08:35
@hperl
Copy link
Contributor

hperl commented Aug 17, 2023

Thanks @jonas-jonas , I pulled in the changes into my PR and will close this one.

@hperl hperl closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants