Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enable, labels, and annotations for selfservice-ui service #701

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bchrobot-mh
Copy link
Contributor

Add support for enabled, labels, and annotations to the kratos-selfservice-ui-node Kubernetes Service.

Related Issue or Design Document

N/A

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

This brings the features of this chart in line with other Ory Helm charts.

Local validation performed with:

helm template kratos-ui . -s templates/service.yaml
helm template kratos-ui . -s templates/service.yaml --set 'service.enabled=false'
helm template kratos-ui . -s templates/service.yaml --set 'service.labels.foo=bar'
helm template kratos-ui . -s templates/service.yaml --set 'service.annotations.foo=bar'

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

@bchrobot-mh bchrobot-mh changed the title feat(selfserve-ui): support enable, labels, and annotations for service feat: support enable, labels, and annotations for selfserve-ui service Aug 28, 2024
@bchrobot-mh bchrobot-mh changed the title feat: support enable, labels, and annotations for selfserve-ui service feat: support enable, labels, and annotations for selfservice-ui service Aug 28, 2024
@Demonsthere Demonsthere merged commit 9a133f6 into ory:master Aug 28, 2024
15 of 17 checks passed
@bchrobot-mh bchrobot-mh deleted the bc-selfservice-ui-service branch August 29, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants