fix: context passing and response size limit #864
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaultier
approved these changes
Sep 9, 2025
vivshankar
reviewed
Sep 9, 2025
| return errorsx.WithStack(ErrInvalidRequestURI.WithHintf("Unable to fetch OpenID Connect request parameters from 'request_uri' because: %s.", err.Error()).WithWrap(err).WithDebug(err.Error())) | ||
| } | ||
| defer response.Body.Close() | ||
| response.Body = io.NopCloser(io.LimitReader(response.Body, 10*1024*1024)) // limit to 10MiB |
There was a problem hiding this comment.
Should the limit be configurable? You could make it a config property in Fosite struct itself.
There was a problem hiding this comment.
I don't think that's necessary. This is a defence mechanism only. Do you think 10MiB is too small?
There was a problem hiding this comment.
Hard to say, particularly with RAR. I don't see any reason why it shouldn't be parameterized.
There was a problem hiding this comment.
I don't see any reason why it shouldn't be parameterized.
The reason is that it's more complicated (more code).
There was a problem hiding this comment.
IMO this should be controlled by the OP using Fosite. Perhaps just a property in the struct? It doesn't have to be a full blown Configurator...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled across this by chance.