-
Notifications
You must be signed in to change notification settings - Fork 58
chore: remove legacy elements #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 42.43% 49.10% +6.67%
==========================================
Files 136 149 +13
Lines 2008 2513 +505
Branches 288 378 +90
==========================================
+ Hits 852 1234 +382
- Misses 1149 1257 +108
- Partials 7 22 +15
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme in the repo now points to a bunch of deleted files, can you please update the readme?
I have some fixes to old elements in my PR for captcha, can we merge that first before merging this? |
And then update the snapshot in the legacy repo |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove development-legacy.md as well? Otherwise lgtm
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments