Skip to content

chore: remove legacy elements #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025
Merged

chore: remove legacy elements #435

merged 13 commits into from
Apr 16, 2025

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Apr 11, 2025
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.10%. Comparing base (f3fad4d) to head (17595a1).
Report is 121 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   42.43%   49.10%   +6.67%     
==========================================
  Files         136      149      +13     
  Lines        2008     2513     +505     
  Branches      288      378      +90     
==========================================
+ Hits          852     1234     +382     
- Misses       1149     1257     +108     
- Partials        7       22      +15     
Components Coverage Δ
@ory/elements-react 45.60% <ø> (+8.81%) ⬆️
@ory/nextjs 63.25% <ø> (-2.73%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonas-jonas jonas-jonas marked this pull request as ready for review April 11, 2025 19:49
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme in the repo now points to a bunch of deleted files, can you please update the readme?

@aeneasr
Copy link
Member

aeneasr commented Apr 14, 2025

I have some fixes to old elements in my PR for captcha, can we merge that first before merging this?

@aeneasr
Copy link
Member

aeneasr commented Apr 14, 2025

And then update the snapshot in the legacy repo

Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 17595a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonas-jonas
Copy link
Member Author

aeneasr
aeneasr previously approved these changes Apr 15, 2025
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove development-legacy.md as well? Otherwise lgtm

@jonas-jonas jonas-jonas merged commit 2bea3d0 into main Apr 16, 2025
9 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/removeLegacy branch April 16, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants