Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vertical nav for quickstart and identity #2020

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

christiannwamba
Copy link
Contributor

@christiannwamba christiannwamba commented Feb 10, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Organization after getting started

@christiannwamba christiannwamba changed the title feat: vertical nav for quickstart feat: vertical nav for quickstart and identity Feb 12, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start :)
i left some comments on what I think could be improved.

one side note for later: if we have the SDK guides as the first starting point in the docs I think we need to make sure that they work very well!

also would be good to have the OAuth2 and Permissions quickstarts under Start as well, but I assume have that planned for a later step.

I hope I caught all the changes but this looks very clean to navigate already!

"getting-started/local-development",
{
type: "category",
label: "Authenctication",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: "Authenctication",
label: "Authentication",

},
{
type: "category",
label: "Credentials",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't the other auth methods like password, passkeys etc. also fall under credentials?
not sure what I would except in this category

"kratos/passwordless/passkeys",
"kratos/passwordless/one-time-code",
"kratos/organizations/organizations",
"kratos/emails-sms/custom-email-templates",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the custom email templates doc is different than the others in this category - maybe it makes sense for emails/communication to have their own category? or move it to the "configuration" category?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants