Make filenames not conflict in TestForEOF #4490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kills an inconsistent failure when running with NoTestReruns. The test tries to verify if our Posix transport does indeed fail on EOF if we read more data than is in the file (when we're not in a mode where we're waiting for more data to be written). The original test write 256 bytes, then tried to read 512 bytes. For some reason this sometimes succeeds rather than fails with an exception. Suspecting that this is because despite living in the same file, sometimes these tests are run concurrently and the first test writes a file of 512 bytes. Change the names so this doesn't happen.