Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filenames not conflict in TestForEOF #4490

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

eisenhauer
Copy link
Member

This kills an inconsistent failure when running with NoTestReruns. The test tries to verify if our Posix transport does indeed fail on EOF if we read more data than is in the file (when we're not in a mode where we're waiting for more data to be written). The original test write 256 bytes, then tried to read 512 bytes. For some reason this sometimes succeeds rather than fails with an exception. Suspecting that this is because despite living in the same file, sometimes these tests are run concurrently and the first test writes a file of 512 bytes. Change the names so this doesn't happen.

@eisenhauer eisenhauer merged commit f6645c5 into ornladios:master Mar 19, 2025
38 of 39 checks passed
@eisenhauer eisenhauer deleted the EOFTest branch March 19, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants