ExplainCommand: use constants for return codes

orisai · Mar 11, 2024 · fdc5636 · fdc5636
1 parent 8d533fb
commit fdc5636
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/Command/ExplainCommand.php b/src/Command/ExplainCommand.php
@@ -65,7 +65,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 	{
 		$options = $this->validateOptions($input, $output);
 		if ($options === null) {
-			return 1;
+			return self::FAILURE;
 		}
 
 		$id = $options['id'];
@@ -182,10 +182,10 @@ private function explainExpression(
 		} catch (InvalidExpression $exception) {
 			$output->writeln("<error>{$exception->getMessage()}</error>");
 
-			return 1;
+			return self::FAILURE;
 		}
 
-		return 0;
+		return self::SUCCESS;
 	}
 
 	private function explainJobWithId(string $id, OutputInterface $output): int
@@ -196,7 +196,7 @@ private function explainJobWithId(string $id, OutputInterface $output): int
 		if ($jobSchedule === null) {
 			$output->writeln("<error>Job with id '$id' does not exist.</error>");
 
-			return 1;
+			return self::FAILURE;
 		}
 
 		$output->writeln($this->explainer->explain(
@@ -205,7 +205,7 @@ private function explainJobWithId(string $id, OutputInterface $output): int
 			$this->computeTimeZone($jobSchedule, $this->clock->now()->getTimezone()),
 		));
 
-		return 0;
+		return self::SUCCESS;
 	}
 
 	private function computeTimeZone(JobSchedule $jobSchedule, DateTimeZone $renderedTimeZone): ?DateTimeZone
@@ -271,7 +271,7 @@ private function explainSyntax(OutputInterface $output): int
 CMD,
 		);
 
-		return 0;
+		return self::SUCCESS;
 	}
 
 }