High-level API for key-exchange using X25519 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycx
commented
Oct 5, 2021
brycx
force-pushed
the
high-level-x25519
branch
from
01ff459 to
72d8942
Compare
brycx
force-pushed
the
high-level-x25519
branch
from
72d8942 to
d86361e
Compare
… it impossible to test with differential-fuzzing
vlmutolo
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Overall this looks awesome. I was really impressed with the simplicity of the API. I mostly understood how to use everything right away. The only small sticking point is what to do once I actually have the SharedKey; I mentioned this in one of my review comments.
vlmutolo
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #213